Split out fastdotcom into a sensor and component#8377
Merged
Conversation
ghost
assigned
8 tasks
rohankapoorcom
added
new-integration
DubhAd
requested changes
Feb 2, 2019
klaasnicolaas
requested changes
Feb 2, 2019
Member
klaasnicolaas
left a comment
klaasnicolaas
left a comment
There was a problem hiding this comment.
We now work with a new way of component pages, so we no longer need to create a separate page for each sensor, switch, etc. but simply attach the information to the main page of the component and delete the sensor page file....
Co-Authored-By: rohankapoorcom <rohan@rohankapoor.com>
Member
Author
@klaasnicolaas can you provide documentation/examples for this? Up until 1 week ago, PRs like this were being accepted: #8296 I'm a little confused when the change happened :) |
Member
|
@rohankapoorcom See this PR from Frenck: #8265 |
rohankapoorcom
force-pushed
the
fastdotcom
branch
from
6f8eadf to
3efa2f1
Compare
Member
Author
|
@klaasnicolaas Thanks for the reference, consolidated down to a single component page. |
rohankapoorcom
commented
Feb 9, 2019
frenck
approved these changes
Feb 11, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fast.com is now a component with a sensor platform.
Pull request in home-assistant (if applicable): home-assistant/core#20341
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.