Extended map to support geo location entities#7880
Merged
Conversation
ghost
added
the
frenck
added
new-feature
frenck
approved these changes
Dec 30, 2018
Member
|
The PR is good, fixed a typo. I've left a comment on the original PR @exxamalte, since it should have been Since this PR matches the merged parent PR, I'll go ahead and merge this one in. |
frenck
added
awaits-parent
Contributor
Author
|
@frenck: I see your point on spelling the config parameter. For some reason, the component started out as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This describes the new configuration option for the map card to display geo location entities. And I added an example illustrating that new option.
I marked
entitiesandgeo_location_sourcesas required, but actually only at least one of the two is required, i.e. either one of the two or both must be defined.Please let me know if there is a smarter way to express this.
Pull request in home-assistant (if applicable): home-assistant/frontend/pull/2337
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.