Revert "MyTotalConnectComfort.com Compatibility (#5771)"#7619
Merged
frenck merged 2 commits intoDec 25, 2018
Conversation
The `honeywell.py` code uses either EvohomeClient *or* somecomfort client code to connect to Honeywell, depending on the region (`eu` or `us` respectively). The somecomfort client exclusively uses mytotalconnectcomfort.com as API. Therefore, this warning seems a little bit premature if you'd ask me.
ghost
added
the
frenck
added
enhancement
next
frenck
removed
the
needs-rebase
frenck
approved these changes
Dec 25, 2018
Member
|
Can be merged as soon as the build passes. |
frenck
added
current
alengwenus
pushed a commit
to alengwenus/home-assistant.io
that referenced
this pull request
Feb 24, 2019
home-assistant#7619) The `honeywell.py` code uses either EvohomeClient *or* somecomfort client code to connect to Honeywell, depending on the region (`eu` or `us` respectively). The somecomfort client exclusively uses mytotalconnectcomfort.com as API. Therefore, this warning seems a little bit premature if you'd ask me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
honeywell.pycode uses eitherEvohomeClientorsomecomfortclient code to connect to Honeywell, depending on the region (euorusrespectively). The somecomfort client exclusively usesmytotalconnectcomfort.comas API. Therefore, this warning seems a little bit premature if you'd ask me.Disclaimer: no personal experience, just based on the code.
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.