Skip to content

Add ID information to Lovelace view page.#7153

Merged
frenck merged 2 commits intohome-assistant:currentfrom
bramkragten:patch-4
Oct 29, 2018
Merged

Add ID information to Lovelace view page.#7153
frenck merged 2 commits intohome-assistant:currentfrom
bramkragten:patch-4

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Oct 27, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#17498

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Oct 27, 2018
@bramkragten bramkragten changed the title Add ID information to view page. Add ID information to Lovelace view page. Oct 27, 2018

You can link to one view from another view by its ID. For this use cards that support navigation (`navigation_path`). Do not use special characters in IDs.

IDs are also used to identify a view for editing, we will add an ID to your view if you don't specify it. You can change this ID, as long as every view has an unique ID.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will help if you clarify the purpose of these IDs. May be we can just indicate that the IDs will be used for things like rearranging UI using drag-and-drop, etc.

id:
required: false
description: IDs are used in the URL, more info below.
description: IDs are used in the URL, more info below. If you don't specify an ID, it will be added automatically
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific format for ID? length?

@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Oct 27, 2018

Let us also add information about the multiline strings as indicated by @frenck here.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the examples as well.

@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo current This PR goes into the current branch parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on and removed to-do labels Oct 27, 2018
@frenck frenck added this to the 0.81 milestone Oct 27, 2018
@bramkragten
Copy link
Copy Markdown
Member Author

What examples? I did the index page here: #7152

@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 27, 2018

@bramkragten Thx! Could you use the PR template, please?
That way stuff gets linked...

@ghost ghost assigned frenck Oct 29, 2018
@ghost ghost added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Oct 29, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 29, 2018

Thanks for updating the docs @bramkragten 👍

@frenck frenck merged commit 9425cf9 into home-assistant:current Oct 29, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants