Skip to content

Add message template support for alert component#6859

Merged
balloob merged 4 commits intohome-assistant:nextfrom
thoscut:next
Nov 1, 2018
Merged

Add message template support for alert component#6859
balloob merged 4 commits intohome-assistant:nextfrom
thoscut:next

Conversation

@thoscut
Copy link
Copy Markdown
Contributor

@thoscut thoscut commented Oct 16, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#17516

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@ghost ghost added the to-do label Oct 16, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Oct 18, 2018
Comment thread source/_components/alert.markdown Outdated
repeat: 30
can_acknowledge: True
skip_first: True
message_template: "Plant {{ states.plant.plant_office }} needs help ({{ state_attr('plant.plant_office', 'problem') }})"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a tab here, please correct

@thoscut
Copy link
Copy Markdown
Contributor Author

thoscut commented Oct 31, 2018

@DubhAd I updated the commit, also made some more changes as I updated the component code as well.

@balloob balloob merged commit 93f22e6 into home-assistant:next Nov 1, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Nov 1, 2018
repeat: 30
can_acknowledge: True
skip_first: True
message: "Plant {{ states.plant.plant_office }} needs help ({{ state_attr('plant.plant_office', 'problem') }})"
Copy link
Copy Markdown
Contributor

@tjorim tjorim Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this example missing the {% raw %} tags?

@tjorim tjorim mentioned this pull request Nov 7, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants