Skip to content

Xmpp http upload#6788

Merged
fabaff merged 7 commits into
home-assistant:nextfrom
flowolf:xmpp_http_upload
Nov 4, 2018
Merged

Xmpp http upload#6788
fabaff merged 7 commits into
home-assistant:nextfrom
flowolf:xmpp_http_upload

Conversation

@flowolf
Copy link
Copy Markdown
Contributor

@flowolf flowolf commented Oct 14, 2018

Description:

Support for sending images through Jabber and HTTP upload (XEP_0363)
added examples for scripts that send images from remote URLs and local files.

Pull request in home-assistant (if applicable): home-assistant/core#17426

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@ghost ghost added the to-do label Oct 14, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Oct 14, 2018
Copy link
Copy Markdown
Contributor

@tjorim tjorim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those double quotes in the configuration section aren't necessary.
I do agree with line 64, but please consider reverting the others.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 4a4ae55 into home-assistant:next Nov 4, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Nov 4, 2018
pszafer pushed a commit to pszafer/home-assistant.io that referenced this pull request Nov 17, 2018
* xmpp http upload documented

* titles, note for rooms

* document unverified request for image retrieval

* reverting some quotes in configuration section

* xmpp docs update

* XMPP HTTP upload: added templating docs for url and path

* fix url template in example n°6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants