Add documentation for new Z-Wave Lock configuration option#6736
Closed
mtreinish wants to merge 3 commits intohome-assistant:nextfrom
Closed
Add documentation for new Z-Wave Lock configuration option#6736mtreinish wants to merge 3 commits intohome-assistant:nextfrom
mtreinish wants to merge 3 commits intohome-assistant:nextfrom
Conversation
This commit adds documentation around setting the new use_notification_state configuration option being added to home-assistant in home-assistant/core#17386
ghost
added
the
mtreinish
changed the title
3 tasks
frenck
added
Hacktoberfest
tjorim
reviewed
Oct 17, 2018
| `use_notification_state` flag for your lock. For example, with an Entity ID for the lock of `lock.my_lock you would set the following in your | ||
| `configuration.yaml`: | ||
|
|
||
| {% configuration %} |
Contributor
There was a problem hiding this comment.
This doesn't look like a configuration variable section.
I think you wanted to use
zwave:
device_config:
lock.my_lock:
use_notification_state: true
frenck
requested changes
Oct 18, 2018
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Hi there, @mtreinish! Thank you for the PR.
I and @tjorim left some comments. Could you please take a look? 👍
frenck
added
in-progress
Co-Authored-By: mtreinish <mtreinish@kortar.org>
Contributor
Author
|
@frenck I've updated the PR per the suggestions. Sorry for the delay |
frenck
approved these changes
Oct 21, 2018
frenck
added
awaits-parent
Member
|
✅ Approved. Can be merged as soon as the parent PR gets merged. |
Contributor
Author
|
No longer using a config option in the parent PR, so the documentation doesn't need to be updated anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This commit adds documentation around setting the new
use_notification_state configuration option being added to
home-assistant in home-assistant/core#17386
Pull request in home-assistant (if applicable): home-assistant/core#17386
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.