Add Elk-M1 sensor platform documentation#6705
Merged
frenck merged 4 commits intohome-assistant:nextfrom Oct 21, 2018
gwww:elkm1-sensor
Merged
Add Elk-M1 sensor platform documentation#6705frenck merged 4 commits intohome-assistant:nextfrom gwww:elkm1-sensor
frenck merged 4 commits intohome-assistant:nextfrom
gwww:elkm1-sensor
Conversation
ghost
added
the
8 tasks
frenck
added
Hacktoberfest
frenck
previously approved these changes
Oct 14, 2018
Member
|
Thanks, @gwww! 👍 ✅ Approved. Can be merged as soon as the parent PR gets merged. |
frenck
added
awaits-parent
frenck
previously approved these changes
Oct 18, 2018
MartinHjelmare
changed the title
| sharing: true | ||
| footer: true | ||
| logo: elkproducts.png | ||
| ha_release: 0.82 |
Contributor
Author
There was a problem hiding this comment.
OK. I'm curious now. How would I ever be able to get the version right?
Member
There was a problem hiding this comment.
@gwww You won't... not until the parent is merged.
A good start is to pick the "next" major version on creation.
frenck
approved these changes
Oct 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
See component PR for full details: home-assistant/core#16952
Pull request in home-assistant (if applicable): home-assistant/core#17342
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.