Add device registry to MQTT binary sensor#6605
Merged
Merged
Conversation
ghost
assigned
4 tasks
OttoWinter
added
the
Hacktoberfest
DubhAd
reviewed
Oct 8, 2018
Contributor
DubhAd
left a comment
DubhAd
left a comment
There was a problem hiding this comment.
Connections example is confusing, showing both [ blah, blah] an [[blah, blah]]
| required: false | ||
| type: list, string | ||
| connections: | ||
| description: 'A list of connections of the device to the outside world as a list of tuples `[connection_type, connection_identifier]`. For example the MAC address of a network interface: `[["mac", "02:5b:26:a8:dc:12"]]`.' |
Contributor
There was a problem hiding this comment.
Should that be single, or double, brackets?
Member
Author
There was a problem hiding this comment.
double brackets. It's a list of 2-tuples.
Member
Author
There was a problem hiding this comment.
I clarified it a bit now by including "connections": in the example config. I'm writing it in JSON format as that's the only way this config option can be used (only over MQTT discovery).
DubhAd
added
awaits-parent
frenck
added
new-feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant (if applicable): home-assistant/core#17243
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.