Move lifx to own component#6565
Merged
frenck merged 4 commits intohome-assistant:nextfrom Oct 9, 2018
Merged
Conversation
7 tasks
amelchio
added
the
Hacktoberfest
frenck
added
new-feature
frenck
previously approved these changes
Oct 7, 2018
frenck
added
awaits-parent
MartinHjelmare
requested changes
Oct 7, 2018
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
We should add a page for the lifx light platform, and direct users to the component page.
frenck
added
in-progress
ghost
added
ready-for-review
source/_components/lifx.markdown
Outdated
| logo: lifx.png | ||
| ha_category: Light | ||
| ha_iot_class: "Local Polling" | ||
| ha_release: 0.12 |
Member
There was a problem hiding this comment.
Update this, since the component is new.
Contributor
Author
There was a problem hiding this comment.
That seems odd but okay. I am not sure what to put into ha_category for the component, though.
source/_components/lifx.markdown
Outdated
| logo: lifx.png | ||
| ha_category: Light | ||
| ha_iot_class: "Local Polling" | ||
| ha_release: 0.80 |
Contributor
Author
There was a problem hiding this comment.
Of course not, thank you :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant (if applicable): home-assistant/core#17201
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.