Skip to content

Cleanup google assistant document#6562

Merged
frenck merged 8 commits into
home-assistant:nextfrom
awarecan:cleanup-google-assistant-document
Oct 7, 2018
Merged

Cleanup google assistant document#6562
frenck merged 8 commits into
home-assistant:nextfrom
awarecan:cleanup-google-assistant-document

Conversation

@awarecan
Copy link
Copy Markdown
Contributor

@awarecan awarecan commented Oct 6, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@ghost ghost assigned awarecan Oct 6, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Oct 6, 2018
frenck
frenck previously approved these changes Oct 6, 2018
@frenck frenck added enhancement next This PR goes into the next branch labels Oct 6, 2018
@frenck frenck changed the base branch from next to current October 6, 2018 19:34
@frenck frenck changed the base branch from current to next October 6, 2018 19:34
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 6, 2018

@awarecan Can you rebase this onto current? Since that should be the target base...

@frenck frenck added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 6, 2018
@awarecan
Copy link
Copy Markdown
Contributor Author

awarecan commented Oct 6, 2018

This is for 0.80 release, should I target current?

@awarecan awarecan force-pushed the cleanup-google-assistant-document branch from 93d1173 to bb5df7f Compare October 6, 2018 20:33
@awarecan awarecan force-pushed the cleanup-google-assistant-document branch from 41713a8 to 18119d7 Compare October 6, 2018 21:53
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 7, 2018

@awarecan, Sorry, next is correct. I jumped on it too early.

@frenck frenck added this to the 0.80 milestone Oct 7, 2018
@ghost ghost assigned frenck Oct 7, 2018
Copy link
Copy Markdown
Contributor

@DubhAd DubhAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DubhAd DubhAd added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Oct 7, 2018
@frenck frenck merged commit 70ecfb8 into home-assistant:next Oct 7, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Oct 7, 2018
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Oct 9, 2018
balloob pushed a commit that referenced this pull request Oct 9, 2018
* Cleanup google assistant document

* Add screenshot for google assistant account linking

* Add migration guide

* Update the additonal users step

* Add note for HTML5 App

* Minor fix

* ✏️ Tweaks

* ✏️ Tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked This PR has been manually picked and merged into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants