Merged
Conversation
OttoWinter
added
Hacktoberfest
4 tasks
frenck
added
next
DubhAd
added
awaits-parent
frenck
requested changes
Oct 8, 2018
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
@OttoWinter Left you some comments, could you please take a look?
| type: device_class | ||
| default: None | ||
| device: | ||
| description: 'Information about the device this sensor is a part of to tie it into the [device registry](https://developers.home-assistant.io/docs/en/device_registry_index.html). Only works through [MQTT discovery](/docs/mqtt/discovery/) and when [`unique_id`](#unique_id) is set.' |
Member
There was a problem hiding this comment.
Some commas would make it more readable (just like the other PRs).
| connections: | ||
| description: 'A list of connections of the device to the outside world as a list of tuples `[connection_type, connection_identifier]`. For example the MAC address of a network interface: `"connections": [["mac", "02:5b:26:a8:dc:12"]]`.' | ||
| required: false | ||
| type: list, tuple |
Member
There was a problem hiding this comment.
tuple is not a valid documentation configuration type.
frenck
added
in-progress
OttoWinter
force-pushed
the
mqtt-device-registry-2
branch
from
0860687 to
358fa0c
Compare
ghost
added
ready-for-review
frenck
approved these changes
Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add device registry integration to MQTT sensors. The plan is to expand it to other platforms too.
Pull request in home-assistant (if applicable): home-assistant/core#16943
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.