Doorbird auth and event data#6245
Merged
arsaboo merged 1 commit intohome-assistant:nextfrom Nov 1, 2018
Merged
Conversation
ghost
added
the
Contributor
Author
|
Replaces #6231 |
frenck
added
new-feature
DubhAd
added
awaits-parent
8 tasks
Contributor
Author
|
What parent PR is this waiting on? |
Member
|
@oblogic7 The one you've listed in the OP: home-assistant/core#16504 |
Contributor
Author
|
Ah. Got lost and thought I was on the main repo. Thanks.
…On Sun, Oct 21, 2018 at 4:54 AM Franck Nijhof ***@***.***> wrote:
@oblogic7 <https://github.com/oblogic7> The one you've listed in the OP:
home-assistant/core#16504
<home-assistant/core#16504>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6245 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbs0OoCsxYvJ_z8-DaHkbl-gVGF2eg9ks5unERcgaJpZM4WgfG0>
.
|
Member
|
@oblogic7 The parent PR has been closed, but since you mentioned something about new PR, I wonder, is this documentation PR still relevant? |
Contributor
Author
|
It will be when I’m done with changes on the other PR
…On Tue, Oct 23, 2018 at 5:26 AM Franck Nijhof ***@***.***> wrote:
@oblogic7 <https://github.com/oblogic7> The parent PR has been closed,
but since you mentioned something about new PR, I wonder, is this
documentation PR still relevant?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6245 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbs0HEDiS9c5Pc-hfu8bz4frP4b4YLbks5unu7WgaJpZM4WgfG0>
.
|
Contributor
|
Since home-assistant/core#14933 has been merged, this needs to be merged as well :) Ping @balloob |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds token/auth config details as well as event_data details.
Description:
Update documentation to match Doorbird auth and event data changes.
Pull request in home-assistant (if applicable): home-assistant/core#14933
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.