Skip to content

Adds documentation for Xiaomi Vibration Sensor#6207

Closed
dlashua wants to merge 1 commit intohome-assistant:currentfrom
dlashua:patch-5
Closed

Adds documentation for Xiaomi Vibration Sensor#6207
dlashua wants to merge 1 commit intohome-assistant:currentfrom
dlashua:patch-5

Conversation

@dlashua
Copy link
Copy Markdown
Contributor

@dlashua dlashua commented Sep 6, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#16422

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@dlashua
Copy link
Copy Markdown
Contributor Author

dlashua commented Sep 6, 2018

This documentation is dependent on home-assistant/core#16422

@frenck frenck changed the title add documentation for vibration sensor Adds documentation for vibration sensor Sep 9, 2018
@frenck frenck changed the title Adds documentation for vibration sensor Adds documentation for Xiaomi Vibration Sensor Sep 9, 2018
@frenck frenck added has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch and removed to-do labels Sep 9, 2018
@syssi
Copy link
Copy Markdown
Member

syssi commented Sep 26, 2018

Please move the example to https://www.home-assistant.io/components/binary_sensor.xiaomi_aqara/ and add the device to the table of "supported sensors" here, too.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlashua Could you take a look at the changes requested by @syssi? Thanks 👍

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Oct 3, 2018
@tjorim
Copy link
Copy Markdown
Contributor

tjorim commented Oct 17, 2018

Can this be closed? #6600, which superseeds this PR, has been merged.

@syssi syssi closed this Oct 17, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Oct 17, 2018
@frenck frenck added the Invalid label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo Invalid new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants