Skip to content

Adds token parameter to Camera.Push#6130

Merged
balloob merged 2 commits intonextfrom
camera.push-token
Sep 11, 2018
Merged

Adds token parameter to Camera.Push#6130
balloob merged 2 commits intonextfrom
camera.push-token

Conversation

@dgomes
Copy link
Copy Markdown
Contributor

@dgomes dgomes commented Aug 31, 2018 •
edited
Loading

Description:
Adds parameter to component and deprecates api_password

Pull request in home-assistant (if applicable): home-assistant/core#16339

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost assigned dgomes Aug 31, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Aug 31, 2018
@dgomes dgomes mentioned this pull request Aug 31, 2018
Merged
8 tasks
@DubhAd
Copy link
Copy Markdown
Contributor

DubhAd commented Sep 1, 2018

Pretty sure doc updates for new features should be next, not current. Can you rebase please.

@dgomes dgomes changed the base branch from current to next September 1, 2018 16:18
@dgomes
Copy link
Copy Markdown
Contributor Author

dgomes commented Sep 1, 2018

Yep! Sorry for that :(

DubhAd
DubhAd approved these changes Sep 1, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@DubhAd DubhAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mistake I may have made/overlooked a few times myself ;)

@DubhAd DubhAd added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Sep 1, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Sep 9, 2018
@balloob balloob added this to the 0.78 milestone Sep 11, 2018
@balloob balloob merged commit 1e77e3a into next Sep 11, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Sep 11, 2018
@balloob balloob deleted the camera.push-token branch September 11, 2018 09:30
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Sep 16, 2018
balloob pushed a commit that referenced this pull request Sep 16, 2018
@dgomes @balloob
Adds token parameter to Camera.Push (#6130)
54063a6 
* Adds token parameter to Camera.Push

* update require
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DubhAd DubhAd DubhAd approved these changes

Assignees

No one assigned

Labels

cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

0.78

Development

Successfully merging this pull request may close these issues.

4 participants

@dgomes @DubhAd @frenck @balloob