Skip to content

update geizhals doc#6026

Merged
frenck merged 2 commits into
home-assistant:nextfrom
JulianKahnert:patch-1
Sep 10, 2018
Merged

update geizhals doc#6026
frenck merged 2 commits into
home-assistant:nextfrom
JulianKahnert:patch-1

Conversation

@JulianKahnert
Copy link
Copy Markdown
Contributor

@JulianKahnert JulianKahnert commented Aug 16, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#15990

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Aug 16, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Aug 16, 2018
@ghost ghost assigned frenck Aug 17, 2018
product_id: 1696985
```

Configuration variables:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you're updating the config block anyway, now would be an ideal time to update this to use the new format as detailed in the documentation standards ;)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by that?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck frenck added the parent-merged The parent PR has been merged already label Sep 9, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 10, 2018

@JulianKahnert That is not required. It is always nice for people to update the documentation as a whole. But just adding the thing that is needed is OK as well.

✅ Approved.

@frenck frenck merged commit 1d7b020 into home-assistant:next Sep 10, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants