Skip to content

Add multiple sensor types for Trafikverket#6006

Merged
MartinHjelmare merged 5 commits intohome-assistant:nextfrom
endor-force:patch-1
Aug 27, 2018
Merged

Add multiple sensor types for Trafikverket#6006
MartinHjelmare merged 5 commits intohome-assistant:nextfrom
endor-force:patch-1

Conversation

@endor-force
Copy link
Copy Markdown
Contributor

@endor-force endor-force commented Aug 13, 2018 •
edited by MartinHjelmare
Loading

Description:
Added precipitation instructions according to code change in sensor. Breaking change in configuration.

Pull request in home-assistant (if applicable): home-assistant/core#15935

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@endor-force
Added precipitation
6484adc 
Added precipitation instructions according to code change in sensor.
@ghost ghost added the to-do label Aug 13, 2018
@endor-force endor-force mentioned this pull request Aug 13, 2018
Merged
8 tasks
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Aug 13, 2018
tjorim
tjorim reviewed Aug 16, 2018
View reviewed changes
source/_components/sensor.trafikverket_weatherstation.markdown Outdated
type: string
type:
description: Defines which temperature you want (`air` or `road`).
description: Defines which data you want (`air`, `road` or `precipitation`).
Copy link
Copy Markdown
Contributor

@tjorim tjorim Aug 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could clarify that the first two are about the temperature?

@endor-force
Copy link
Copy Markdown
Contributor Author

endor-force commented Aug 17, 2018

I will investigate possibilities to extend and use pytrafikverket lib..

@endor-force
Updated to match breaking changes
0a27eda 
Breaking changes introduced new way of retreiving data from weatherstations using library.
Multiple sensors added and configuration needs to be update.
@endor-force endor-force changed the title Added precipitation Added multiple sensor types for Trafikverket - Breaking change in configuration Aug 26, 2018
MartinHjelmare
MartinHjelmare requested changes Aug 27, 2018
View reviewed changes
source/_components/sensor.trafikverket_weatherstation.markdown
```

{% configuration %}
name:

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

MartinHjelmare
MartinHjelmare reviewed Aug 27, 2018
View reviewed changes
source/_components/sensor.trafikverket_weatherstation.markdown Outdated
required: true
type: string
monitored_conditions:
description: Conditions to display in the frontend.
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have anything to do with the frontend per se, but decides what entities will be created for the platform, ie what states to track.

Copy link
Copy Markdown
Contributor Author

@endor-force endor-force Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good input, i will clarify

MartinHjelmare
MartinHjelmare previously approved these changes Aug 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you can add ha_iot_class too to the front matter that would be good. It should be cloud polling.

@endor-force
Added ha_iot_class
b47d543 
ha_iot_class: "Cloud Polling" Added in header.
@endor-force
Copy link
Copy Markdown
Contributor Author

endor-force commented Aug 27, 2018

Done, don't really know why it says i dismissed your review ;)

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Aug 27, 2018

We've set up github to automatically do that when new changes are pushed to require a new review.

@MartinHjelmare MartinHjelmare changed the title Added multiple sensor types for Trafikverket - Breaking change in configuration Add multiple sensor types for Trafikverket - Breaking change in configuration Aug 27, 2018
@MartinHjelmare MartinHjelmare changed the title Add multiple sensor types for Trafikverket - Breaking change in configuration Add multiple sensor types for Trafikverket Aug 27, 2018
@MartinHjelmare MartinHjelmare merged commit b31ed71 into home-assistant:next Aug 27, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Aug 27, 2018
@endor-force endor-force deleted the patch-1 branch August 29, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

+1 more reviewer

@tjorim tjorim tjorim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@endor-force @MartinHjelmare @tjorim @frenck