Skip to content

Update for precipitation instructions#5998

Closed
endor-force wants to merge 20 commits intohome-assistant:nextfrom
endor-force:patch-1
Closed

Update for precipitation instructions#5998
endor-force wants to merge 20 commits intohome-assistant:nextfrom
endor-force:patch-1

Conversation

@endor-force
Copy link
Copy Markdown
Contributor

@endor-force endor-force commented Aug 12, 2018

Description:
Added precipitation type as possible object in sensor component.

Pull request in home-assistant (if applicable): home-assistant/core#15935

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

DetroitEE and others added 11 commits July 30, 2018 09:08
Update media_player.webostv.markdown
Taking out the "new and experimental" note - we're a dozen releases on, it's hardly new and seems to be (from a feature sense) stable.

Re-written para 2 to reflect that HA needs shut down, and that 0.75 introduced the "future" UI. Re-written the supported components list because it's horribly out of date, and without trawling the code it's impossible to know what's supported.
* Update device-specific.markdown

Homeseer devices seem to now send different data for Central Scene commands. IDs are the same, data changed significantly.

* Minor change
Adding the warning here, rather than just lurking in the templating docs.
Making the warning clearer (I'll add something similar to the template trigger docs), and putting a title in so that we can link to it.
Added precipitation type as possible object in sensor component.
@ghost ghost added the to-do label Aug 12, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration in-progress This PR/Issue is currently being worked on has-parent This PR has a parent PR in another repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch and removed to-do labels Aug 13, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 13, 2018

Hi there @endor-force!

This PR has a parent PR in our code base, and should, therefore, target the next branch. Please update the target branch of this PR and rebase if needed.

Thanks!

@endor-force endor-force changed the base branch from current to next August 13, 2018 10:47
@endor-force
Copy link
Copy Markdown
Contributor Author

@frenck Thanks, changed to next branch, not sure how to verify if rebase is needed, does it look ok like this or what should i look for?

@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 13, 2018

Well @endor-force, there are commits in your PR that are not yours.
So yeah, you'll need to rebase to clean that up.

DubhAd and others added 7 commits August 13, 2018 14:10
Taking out the "new and experimental" note - we're a dozen releases on, it's hardly new and seems to be (from a feature sense) stable.

Re-written para 2 to reflect that HA needs shut down, and that 0.75 introduced the "future" UI. Re-written the supported components list because it's horribly out of date, and without trawling the code it's impossible to know what's supported.
* Update device-specific.markdown

Homeseer devices seem to now send different data for Central Scene commands. IDs are the same, data changed significantly.

* Minor change
Adding the warning here, rather than just lurking in the templating docs.
Making the warning clearer (I'll add something similar to the template trigger docs), and putting a title in so that we can link to it.
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Aug 13, 2018
@endor-force endor-force deleted the patch-1 branch August 13, 2018 12:14
@endor-force endor-force restored the patch-1 branch August 13, 2018 12:14
@endor-force
Copy link
Copy Markdown
Contributor Author

Unable to rebase, probably due to incompetence from my side. New PR 6006 created to next branch accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants