Skip to content

Update HomematicIP#5959

Closed
worm-ee wants to merge 1 commit intohome-assistant:currentfrom
worm-ee:update-homematicip_cloud
Closed

Update HomematicIP#5959
worm-ee wants to merge 1 commit intohome-assistant:currentfrom
worm-ee:update-homematicip_cloud

Conversation

@worm-ee
Copy link
Copy Markdown
Contributor

@worm-ee worm-ee commented Aug 5, 2018

Description:

  • Add description for Integrations configuration
  • Fix configuration.yaml file formating issue
  • Add supported devices list

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Aug 5, 2018
@worm-ee worm-ee mentioned this pull request Aug 5, 2018
Merged
6 tasks
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on has-parent This PR has a parent PR in another repo and removed to-do ready-for-review This PR needs to be reviewed labels Aug 6, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 6, 2018

This PR targets an incorrect branch. It should be targeting next since it has code changes upstream.
Please rebase.

@worm-ee
Copy link
Copy Markdown
Contributor Author

worm-ee commented Aug 6, 2018

New PR: #5966

@worm-ee worm-ee closed this Aug 6, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@worm-ee worm-ee

Labels

has-parent This PR has a parent PR in another repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@worm-ee @frenck