Skip to content

Allow wait template to run the remainder of the script#5954

Merged
frenck merged 4 commits intohome-assistant:nextfrom
lhovo:next
Aug 13, 2018
Merged

Allow wait template to run the remainder of the script#5954
frenck merged 4 commits intohome-assistant:nextfrom
lhovo:next

Conversation

@lhovo
Copy link
Copy Markdown
Contributor

@lhovo lhovo commented Aug 5, 2018

Breaking changes
The wait template will now continue to run the remainder of the script on timeout, the original functionality can be gained by setting continue_on_timeout: 'false'.

Description:

This allows the Wait Template script to use a timer to continue running the script if timeout is reached vs the current behaviour of exiting.
This is achieved by setting a new flag 'proceed' to 'true' in the config.
By default this flag is set to 'false' and is optional to ensure this is not a breaking change.
For this flag to work the optional 'timeout' is required to be set also.

home-assistant/core#15836

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Aug 5, 2018
@fabaff fabaff changed the title New feature: Allow wait template to run the remainder of the script Allow wait template to run the remainder of the script Aug 5, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Aug 5, 2018
@frenck frenck self-assigned this Aug 13, 2018
@frenck frenck self-requested a review August 13, 2018 10:40
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Aug 13, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 13, 2018

Thank you @lhovo! This looks great and really awesome feature! 👍

@frenck frenck merged commit def92b9 into home-assistant:next Aug 13, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Aug 13, 2018
@frenck frenck removed their assignment Aug 13, 2018
flo-wer pushed a commit to flo-wer/home-assistant.io that referenced this pull request Aug 17, 2018
…t#5954)

* Adding new proceed variable

* Fixing documentation langauage

* Updating documentation due to code changes

* Changing default to continue to execute after delay
flo-wer pushed a commit to flo-wer/home-assistant.io that referenced this pull request Aug 17, 2018
…t#5954)

* Adding new proceed variable

* Fixing documentation langauage

* Updating documentation due to code changes

* Changing default to continue to execute after delay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants