Skip to content

Update Roomba to reflect the new state of things#5939

Closed
arbreng wants to merge 1 commit intohome-assistant:nextfrom
arbreng:roomba-refactor
Closed

Update Roomba to reflect the new state of things#5939
arbreng wants to merge 1 commit intohome-assistant:nextfrom
arbreng:roomba-refactor

Conversation

@arbreng
Copy link
Copy Markdown

@arbreng arbreng commented Aug 1, 2018 •
edited
Loading

Description:
Updated to reflect that the platform is no longer a toggle and therefor won't support turn_on and turn_off.

Pull request in home-assistant (if applicable): home-assistant/core#15779

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Aug 1, 2018
@arbreng arbreng mentioned this pull request Aug 1, 2018
Closed
3 tasks
@arbreng
Copy link
Copy Markdown
Author

arbreng commented Aug 1, 2018

Part of: home-assistant/architecture#29

@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Aug 1, 2018
DubhAd
DubhAd approved these changes Aug 18, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@DubhAd DubhAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Aug 22, 2018
@stale
Copy link
Copy Markdown

stale Bot commented Oct 21, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale The PR had no activity for quite some time, and is marked as Stale label Oct 21, 2018
@stale stale Bot closed this Oct 28, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Oct 28, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 29, 2018

Parent is still open, reopening PR.

@frenck frenck reopened this Oct 29, 2018
@stale stale Bot removed the stale The PR had no activity for quite some time, and is marked as Stale label Oct 29, 2018
@ghost ghost assigned frenck Oct 29, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Oct 29, 2018
@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Oct 29, 2018
frenck
frenck requested changes Oct 29, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbreng Merge conflicts have occurred!
Could you please take a look and resolve them? 👍

@frenck frenck assigned arbreng and unassigned frenck Oct 29, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 24, 2018

Closing this PR, since the parent PR has been closed as well.

@frenck frenck closed this Dec 24, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck requested changes

@DubhAd DubhAd DubhAd approved these changes

Assignees

@arbreng arbreng

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arbreng @frenck @DubhAd