Skip to content

Added docs for state attributes in Dyson fan#5938

Merged
frenck merged 1 commit into
home-assistant:nextfrom
soraxas:dysonfan
Aug 13, 2018
Merged

Added docs for state attributes in Dyson fan#5938
frenck merged 1 commit into
home-assistant:nextfrom
soraxas:dysonfan

Conversation

@soraxas
Copy link
Copy Markdown
Contributor

@soraxas soraxas commented Aug 1, 2018

Description:
Added descriptino of the newly added state attributes in dyson fan devices.

Pull request in home-assistant (if applicable): home-assistant/core#15716

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Aug 1, 2018
@frenck frenck removed the to-do label Aug 1, 2018
@frenck frenck changed the base branch from current to next August 1, 2018 11:51
@frenck frenck changed the base branch from next to current August 1, 2018 11:51
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration in-progress This PR/Issue is currently being worked on has-parent This PR has a parent PR in another repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 1, 2018
frenck
frenck previously approved these changes Aug 1, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.

@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 1, 2018

@soraxas Thank you for the PR.
Documentation for a new platform, component and/or features should target the next branch.
Please rebase your PR.

@soraxas
Copy link
Copy Markdown
Contributor Author

soraxas commented Aug 1, 2018

Apology for that! I initially thought this counts toward fixes, changes, and adjustment, but completely overlooked this as new features. Thanks for letting me know, will rebase it soon.

@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 1, 2018

@soraxas I understand the confusion.
If the code base changes, it will be staged for the next release right? As in, changing the current documentation would cause the documentation to not match 😉

@soraxas soraxas changed the base branch from current to next August 2, 2018 05:43
@soraxas
Copy link
Copy Markdown
Contributor Author

soraxas commented Aug 2, 2018

Hi! Is this approach correct? I rebased only my commit onto next and force pushed it. It's my first time rebasing PR so let me know if it's incorrect. Thanks! :)

@frenck frenck added ready-for-review This PR needs to be reviewed and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 4, 2018
@frenck frenck assigned frenck and unassigned soraxas Aug 4, 2018
@frenck frenck added next This PR goes into the next branch and removed in-progress This PR/Issue is currently being worked on labels Aug 4, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 6, 2018

Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Aug 6, 2018
@frenck frenck removed their assignment Aug 6, 2018
@frenck frenck self-assigned this Aug 13, 2018
@frenck frenck added this to the 0.76 milestone Aug 13, 2018
@frenck frenck merged commit ba12a56 into home-assistant:next Aug 13, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Aug 13, 2018
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Aug 14, 2018
balloob pushed a commit that referenced this pull request Aug 14, 2018
@soraxas @balloob
added docs for added attributes for dyson fan (#5938)
002833d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

@frenck frenck

Labels

cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

0.76

Development

Successfully merging this pull request may close these issues.

3 participants

@soraxas @frenck @balloob