Add documentation for the new Ecovacs (Deebot) component and vacuum#5922
Merged
balloob merged 3 commits intohome-assistant:nextfrom Aug 20, 2018
Merged
Add documentation for the new Ecovacs (Deebot) component and vacuum#5922balloob merged 3 commits intohome-assistant:nextfrom
balloob merged 3 commits intohome-assistant:nextfrom
Conversation
ghost
assigned
7 tasks
frenck
added
new-integration
DubhAd
reviewed
Aug 18, 2018
Contributor
DubhAd
left a comment
DubhAd
left a comment
There was a problem hiding this comment.
One typo, two template recommendations
| sucks: debug | ||
| ``` | ||
|
|
||
| Warning: doing this will cause your authentication token to visibie in your log files. Be sure to remove any tokens and other authentication details from your log before posting them in an issue. No newline at end of file |
Contributor
There was a problem hiding this comment.
Typo: visibie should be visible
| vacuum_filter: | ||
| friendly_name: "Vacuum Filter Remaining Lifespan" | ||
| unit_of_measurement: '%' | ||
| value_template: "{{ states.vacuum.my_vacuum_id.attributes.component_filter }}" |
Contributor
There was a problem hiding this comment.
value_template: "{{ state_attr('vacuum.my_vacuum_id', 'component_filter') }}"
will avoid any errors if the component is still being set up
| vacuum_filter_replace: | ||
| friendly_name: "Vacuum Filter" | ||
| device_class: problem | ||
| value_template: "{{ states.vacuum.my_vacuum_id.attributes.component_main_brush <= 5 }}" |
Contributor
There was a problem hiding this comment.
value_template: "{{ state_attr('vacuum.my_vacuum_id', 'component_main_brush') <= 5 }}"
From PR review
Contributor
Author
|
@DubhAd Thanks; fixed! |
balloob
approved these changes
Aug 20, 2018
Member
|
Good job me merging while ha_release was not correct 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
New Ecovacs component which creates vacuums. Some extra disclaimers in this one due to how new the upstream library currently is
Pull request in home-assistant (if applicable): home-assistant/core#15520
Checklist:
current. New documentation for platforms/components and features should go tonext.