Skip to content

Add documentation and logo for Aladdin Connect cover#5903

Merged
MartinHjelmare merged 2 commits intohome-assistant:nextfrom
shoejosh:aladdin-connect
Jul 31, 2018
Merged

Add documentation and logo for Aladdin Connect cover#5903
MartinHjelmare merged 2 commits intohome-assistant:nextfrom
shoejosh:aladdin-connect

Conversation

@shoejosh
Copy link
Copy Markdown
Contributor

Description:
Documentation for Aladdin Connect Cover

Pull request in home-assistant (if applicable): home-assistant/core#15699

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Jul 27, 2018
@DubhAd DubhAd added the has-parent This PR has a parent PR in another repo label Jul 28, 2018
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch and removed to-do labels Jul 29, 2018
frenck
frenck previously approved these changes Jul 29, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 29, 2018

Thank you, @shoejosh! Those are some pretty nice additions to the project 👍
✅ Approved. Can be merged as soon as the parent PR get merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Jul 29, 2018
logo: aladdin_connect.png
ha_category: Cover
ha_release: 0.75
---
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ha_iot_class to the front matter. I assume the value should be Cloud Polling.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted @MartinHjelmare!

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed awaits-parent Awaits the merge of an parent PR labels Jul 30, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 30, 2018

@shoejosh, can you take a look? 👍

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 01fa261 into home-assistant:next Jul 31, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Jul 31, 2018
@balloob balloob added this to the 0.75 milestone Aug 3, 2018
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Aug 3, 2018
balloob pushed a commit that referenced this pull request Aug 3, 2018
* Add documentation and logo for Aladdin Connect cover

* Add ha_iot_class to header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants