Xiaomi Vacuum: Updated to reflect that it is no longer a toggle#5902
Merged
fabaff merged 2 commits intohome-assistant:nextfrom Aug 13, 2018
Merged
Xiaomi Vacuum: Updated to reflect that it is no longer a toggle#5902fabaff merged 2 commits intohome-assistant:nextfrom
fabaff merged 2 commits intohome-assistant:nextfrom
Conversation
ghost
added
the
2 tasks
frenck
added
new-feature
frenck
previously approved these changes
Jul 29, 2018
Member
|
Thanks, @cnrd! ✅ Approved. Can be merged as soon as the parent PR gets merged. |
frenck
added
awaits-parent
|
Part of home-assistant/architecture#29 |
arbreng
reviewed
Aug 1, 2018
| @@ -17,11 +17,9 @@ The `xiaomi miio` vacuum platform allows you to control the state of your [Xiaom | |||
|
|
|||
| Currently supported features are: | |||
|
|
|||
arbreng
reviewed
Aug 1, 2018
|
|
||
| - `turn_on` | ||
| - `pause` | ||
| - `stop` |
There was a problem hiding this comment.
Does 'stop' work for you? It's broken for my Roomba; I get a nice stacktrace
arbreng
reviewed
Aug 1, 2018
| In addition to all of the services provided by the `vacuum` component (`start_pause`, `stop`, `return_to_home`, `locate`, `set_fan_speed` and `send_command`), the `xiaomi` platform introduces specific services to access the remote control mode of the robot. These are: | ||
|
|
||
| - `xiaomi_remote_control_start` | ||
| - `xiaomi_remote_control_stop` |
frenck
added
ready-for-review
flo-wer
pushed a commit
to flo-wer/home-assistant.io
that referenced
this pull request
Aug 17, 2018
…-assistant#5902) * Updated to reflect that it is no longer a toggle * Added start as a supported feature and split up start_pause
flo-wer
pushed a commit
to flo-wer/home-assistant.io
that referenced
this pull request
Aug 17, 2018
…-assistant#5902) * Updated to reflect that it is no longer a toggle * Added start as a supported feature and split up start_pause
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updated to reflect that the platform is no longer a toggle and therefor won't support
turn_onandturn_off.Pull request in home-assistant (if applicable): home-assistant/core#15643
Checklist:
current. New documentation for platforms/components and features should go tonext.