Skip to content

(Ignore) Add STATE_AUTO support to generic_thermostat#5898

Closed
niklaswa wants to merge 102 commits intohome-assistant:nextfrom
niklaswa:patch-3
Closed

(Ignore) Add STATE_AUTO support to generic_thermostat#5898
niklaswa wants to merge 102 commits intohome-assistant:nextfrom
niklaswa:patch-3

Conversation

@niklaswa
Copy link
Copy Markdown
Contributor

@niklaswa niklaswa commented Jul 26, 2018

Description:
Make the user aware of what STATE_AUTO does.

Pull request in home-assistant (if applicable): home-assistant/core#15678

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

balloob and others added 30 commits July 16, 2018 09:01
@balloob
Add draft blogpost for 0.74
d81b88f
@balloob
Update intro text in hero banner
f35fe9f
@ciotlosm @balloob
Updates for future beta (#5792)
6ab42a8 
* Updates for future beta

* Update views changelog

* Updated based on PR feedback
@collse
Update index.markdown (#5803)
0f7db28 
outdated config - corrected
@pvizeli
Update installation.markdown
5c1dafd
@balloob
Blogpost 73.2
3296a88
@robmarkcole @frenck
Fix HassOS setup docs (#5807)
e29b581 
Addresses home-assistant/operating-system#110 (comment)
@balloob
Update cloud nav
835ed38
@balloob
Update changelog.markdown
e3f4975
@balloob
Add note about python 3.4
63c31d4
@balloob
Link to Pi 3B+
8aee32d
@balloob
Update installation.markdown
be3e383
@balloob
Link to all Hass.io device types, as we'll get more.
46a02ae
@balloob
Update installation.markdown
5fae1eb
@Dmurph24 @fabaff
Update vacuum.xiaomi_miio.markdown (#5812)
324504b
@pvizeli
Update installation.markdown
744e0c8
@dshokouhi @arsaboo
Update URL To Link To All Supported Botvacs (#5818)
c0f5038
@balloob
Add cloud troubleshooting
928dd5d
@rrubin0 @arsaboo
Added Setting Lovelace as Default UI (#5824)
7bc15cd 
seems simple once you know, but placing a reference here is certainly helpful for new folks.
@balloob
Lovelace: Overwrite name in history card (#5797)
92543a4
@huangyupeng @balloob
Add Tuya light platform document (#5800)
6306fa4 
* Add Tuya light document

* fix grammar problem
@balloob
Lovelace: Add column width for glance + fix key name (#5811)
570d4fe
@balloob
Lovelace: Add secondary info docs (#5816)
4dbb5c2
@balloob
Lovelace: Make cards[] optional in a view (#5823)
9a760ce
@jeradM @balloob
Update picture-elements docs. (#5830)
ca9fc46
@nightowlengineer @fabaff
Fix minor typo in template docs (#5829)
38999bd
@goto100 @fabaff
Update sensor.waqi.markdown (#5826)
fff30ba 
Use the example code actually not working due to the Beijing US Embassy station changed it's name.
@balloob
Update blogpost for 74
f8674d0
@balloob
Fixes from Frenck
20f4bdd
@balloob
Update date
4f10821
glogiotatidis and others added 11 commits July 24, 2018 22:15
@glogiotatidis @fabaff
Fix link to supported currencies (#5860)
1549264
@fabaff
Lovelace: pic elements add default style (#5876)
d66f85e
@curry684 @fabaff
Add instruction for restarting with Docker Compose (#5879)
bf69a5f
@tjorim @fabaff
Space in wrong place (#5882)
f803ce8
@peternijssen @fabaff
fixed a typo in the postnl sensor (#5883)
365499c
@balloob
JuanMT to replace BRUH
0e700a4
@jlauwers @fabaff
OpenEnergyMonitor typo (#5894)
b0d9ea0
@Timple @fabaff
Modify delay example to support decimals and large numbers (#5890)
4e39cba 
* Modify delay example to support decimals and large numbers

* Forgot quotation marks
@balloob
Extract hass.io command line
0a7a02a
@starbuck93 @fabaff
Added example for using templates (#5886)
ca5b2de 
* Added example for using templates

Also added example automation with using templates and some sample headers in the configuration.

* Minor changes
@niklaswa
Add STATE_AUTO support to generic_thermostat
2253629 
Documentation to home-assistant/core#15678
@ghost ghost added the to-do label Jul 26, 2018
@niklaswa niklaswa mentioned this pull request Jul 26, 2018
Merged
3 tasks
@DubhAd DubhAd added the has-parent This PR has a parent PR in another repo label Jul 28, 2018
@frenck frenck added ready-for-review This PR needs to be reviewed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on and removed to-do ready-for-review This PR needs to be reviewed labels Jul 29, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 29, 2018

@niklaswa, thank you for this, nevertheless, the PR is targeted against the wrong branch.
Since this relies on a featured pending a parent PR in our code base, the documentation should go into the next branch. Please rebase.

@niklaswa niklaswa changed the base branch from current to next July 29, 2018 07:55
@niklaswa
Copy link
Copy Markdown
Contributor Author

niklaswa commented Jul 29, 2018 •
edited
Loading

Done. Looks weird but I hope that was right? 👀 @frenck

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 29, 2018

Yeah, it does, you should have rebased instead of changing the target in GitHub and merge in next.
Because of your actions, probably the only solution now is to close this PR and create a new one.

@niklaswa
Copy link
Copy Markdown
Contributor Author

niklaswa commented Jul 29, 2018

New one #5916 @frenck

@niklaswa niklaswa closed this Jul 29, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Jul 29, 2018
@niklaswa niklaswa changed the title Add STATE_AUTO support to generic_thermostat (Ignore) Add STATE_AUTO support to generic_thermostat Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@niklaswa niklaswa

Labels

has-parent This PR has a parent PR in another repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.