Skip to content

Add documentation for netatmo public component#5893

Merged
frenck merged 7 commits intohome-assistant:nextfrom
colinfrei:patch-3
Aug 13, 2018
Merged

Add documentation for netatmo public component#5893
frenck merged 7 commits intohome-assistant:nextfrom
colinfrei:patch-3

Conversation

@colinfrei
Copy link
Copy Markdown
Contributor

@colinfrei colinfrei commented Jul 25, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#15684

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Jul 25, 2018
@DubhAd DubhAd added the has-parent This PR has a parent PR in another repo label Jul 28, 2018
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch and removed to-do labels Jul 29, 2018
@ghost ghost assigned frenck Jul 29, 2018
lon_sw: -74.105
```

Configuration variables:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated that. Looks like I missed that part in the docs, and the example I looked at wasn't using that tag.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 29, 2018

Hi there @colinfrei, thank you for sending in this PR.
I've reviewed it and left you some feedback. Could you please take a look? 👍

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Jul 29, 2018
@frenck frenck assigned colinfrei and unassigned frenck Jul 29, 2018
@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Aug 4, 2018
@ghost ghost assigned frenck Aug 9, 2018
frenck
frenck previously approved these changes Aug 9, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 9, 2018

Thanks, @colinfrei!

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Aug 9, 2018
@frenck frenck removed their assignment Aug 9, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@frenck frenck merged commit 2570547 into home-assistant:next Aug 13, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Aug 13, 2018
flo-wer pushed a commit to flo-wer/home-assistant.io that referenced this pull request Aug 17, 2018
* Add documentation for netatmo public component

* ✏️ Minor typo

* Use configuration block instead of plain text

* Change version and clarify that sensor is rain-only

* 🔥 Removes duplicate configuration variables header

* ✏️ Tweaks

* Update 'ha_releases'
flo-wer pushed a commit to flo-wer/home-assistant.io that referenced this pull request Aug 17, 2018
* Add documentation for netatmo public component

* ✏️ Minor typo

* Use configuration block instead of plain text

* Change version and clarify that sensor is rain-only

* 🔥 Removes duplicate configuration variables header

* ✏️ Tweaks

* Update 'ha_releases'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants