Skip to content

lovelace glance docs - should show_title actually be show_name?#5810

Closed
jimbob1001 wants to merge 4 commits intohome-assistant:nextfrom
jimbob1001:patch-4
Closed

lovelace glance docs - should show_title actually be show_name?#5810
jimbob1001 wants to merge 4 commits intohome-assistant:nextfrom
jimbob1001:patch-4

Conversation

@jimbob1001
Copy link
Copy Markdown
Contributor

@jimbob1001 jimbob1001 commented Jul 17, 2018

Description:

I think the docs should say show_name and not show_title

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Jul 17, 2018
@jimbob1001 jimbob1001 changed the title should show_title actually be show_name? lovelace glance docs - should show_title actually be show_name? Jul 17, 2018
@c727
Copy link
Copy Markdown
Contributor

c727 commented Jul 17, 2018

next is the correct branch for this

@c727 c727 added needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch and removed to-do labels Jul 17, 2018
@jimbob1001 jimbob1001 changed the base branch from rc to next July 17, 2018 13:00
@jimbob1001
Copy link
Copy Markdown
Contributor Author

changed to next

@c727
Copy link
Copy Markdown
Contributor

c727 commented Jul 17, 2018

I included the fixes here #5811
You have other commits in your PR now. Next time make sure to read the checkboxes in PR template.

thanks all in all 👍

@c727 c727 closed this Jul 17, 2018
@jimbob1001 jimbob1001 deleted the patch-4 branch July 17, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants