Lovelace: correct glance config#5758
Merged
Merged
Conversation
ghost
assigned
frenck
added
Fix/Formatting/Language/Spelling
current
DubhAd
reviewed
Jul 11, 2018
| entities: | ||
| required: true | ||
| description: "A list of entity IDs or an `entity` object." | ||
| description: "A list of entity IDs or a `entity` objects." |
Contributor
There was a problem hiding this comment.
a entity objects doesn't make sense, maybe entity objects
fabaff
previously requested changes
Jul 11, 2018
| name: | ||
| required: true | ||
| description: "A name for `the entity_id`." | ||
| type: string |
Member
There was a problem hiding this comment.
According to sample below those are valid keys. From my point of view those needs to be documented.
Contributor
Author
There was a problem hiding this comment.
The keys there are optional. Yep, I will add a new setion for this
DubhAd
reviewed
Jul 12, 2018
| name: | ||
| required: false | ||
| description: Overwrites friendly name. | ||
| type: string |
Contributor
There was a problem hiding this comment.
In the entities card docs it says that type is an entity option, but it's not listed here. Is an entity different in different cards?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
correct glance config
Checklist:
current. New documentation for platforms/components and features should go tonext.