Skip to content

Rework lovelace views page#5738

Merged
frenck merged 5 commits into
currentfrom
c727-ll-views
Jul 11, 2018
Merged

Rework lovelace views page#5738
frenck merged 5 commits into
currentfrom
c727-ll-views

Conversation

@c727
Copy link
Copy Markdown
Contributor

@c727 c727 commented Jul 10, 2018

Description:

  • added config for more keys
  • simplified examples
  • kiss

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost assigned c727 Jul 10, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Jul 10, 2018
@c727 c727 changed the title Rework lovelace views page Wip Rework lovelace views page Jul 10, 2018
@frenck frenck added in-progress This PR/Issue is currently being worked on current This PR goes into the current branch labels Jul 10, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 10, 2018

@c727 Build failed?

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Jul 10, 2018

it has something to do with the config block. the build system sucks, I need 13min for a build and changes don't pick up. Also the error output is a joke

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 10, 2018

@c727 Known issue... Jekyll 😢
Recommendation: Setup a local environment (much quicker).

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Jul 10, 2018

...that's what I'm talking about

required: true
description: List of cards to render in this view.
type: list
id:
Copy link
Copy Markdown
Contributor

@sjabby sjabby Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs to be "id" to validate with netlify.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Jul 11, 2018
@c727 c727 changed the title Wip Rework lovelace views page Rework lovelace views page Jul 11, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 11, 2018

👍

@frenck frenck merged commit f0dd1bb into current Jul 11, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jul 11, 2018
@frenck frenck deleted the c727-ll-views branch July 11, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants