Skip to content

Documentation for Cloudflare#5723

Merged
fabaff merged 8 commits into
home-assistant:nextfrom
ludeeus:cloudflare
Jul 9, 2018
Merged

Documentation for Cloudflare#5723
fabaff merged 8 commits into
home-assistant:nextfrom
ludeeus:cloudflare

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Jul 9, 2018

Description:
This PR adds documentation for the Cloudflare component.

Pull request in home-assistant (if applicable): home-assistant/core#15388

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Jul 9, 2018
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Jul 9, 2018
Comment thread source/_components/cloudflare.markdown Outdated
- 'www'
```

{% configuration duckdns %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duckdns?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... used that one as a template since the function i similar, updated the PR now

@ghost ghost assigned frenck Jul 9, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done @ludeeus 👍

email: user@example.com
api_key: c2547eb745079dac9320b638f5e225cf483cc5cfdda41
zone: example.com
records:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps a user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment is no longer valid.

frenck
frenck previously approved these changes Jul 9, 2018
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Jul 9, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 9, 2018

LGTM @ludeeus 👍
✅ Approved. Can be merged as soon as the parent PR gets merged in.

@frenck frenck removed their assignment Jul 9, 2018
fabaff
fabaff previously approved these changes Jul 9, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 8ac7b4c into home-assistant:next Jul 9, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants