Add RelayAddr/Chan to Alarmdecoder#5645
Merged
frenck merged 4 commits intohome-assistant:nextfrom Jul 21, 2018
digiblur:next
Merged
Add RelayAddr/Chan to Alarmdecoder#5645frenck merged 4 commits intohome-assistant:nextfrom digiblur:next
frenck merged 4 commits intohome-assistant:nextfrom
digiblur:next
Conversation
ghost
added
the
3 tasks
frenck
added
new-feature
frenck
requested changes
Jul 2, 2018
| 02: | ||
| name: 'Front Door' | ||
| type: 'opening' | ||
| 03: |
Member
There was a problem hiding this comment.
We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps a user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.
Contributor
Author
There was a problem hiding this comment.
I do agree with the changes. To follow with this the rule rfid should also be removed from zone 1 that is not part of my current proposed changes.
| - **panel_display** (*Optional*): Create a sensor called sensor.alarm_display to match the Alarm Keypad display. Default: `off` | ||
| - **zones** (*Optional*): AlarmDecoder has no way to tell us which zones are actually in use, so each zone must be configured in Home Assistant. For each zone, at least a name must be given. For more information on the available zone types, take a look at the [Binary Sensor](/components/binary_sensor.alarmdecoder/) docs. *Note: If no zones are specified, Home Assistant will not load any binary_sensor components.* | ||
| - **rfid** (*Optional*): The RF serial-number associated with RF zones. Providing this field allows Home Assistant to associate raw sensor data to a given zone, allowing direct monitoring of the state, battery, and supervision status. | ||
| - **relayaddr** (*Optional*): Address of the relay expander board to associate with the zone. (ex: 12, 13, 14, or 15). Typically used in cases where a panel will not send bypassed zones such as motion during an armed home state, the Vista 20P is an example of this. Alarmdecoder can emulate a zone expander board and the panel can be programmed to push zone events to this virtual expander. This allows the bypassed zone binary sensors to be utilized. One example is using bypassed motion sensors at night for motion based automated lights while the system is armed with the motion sensor bypassed. |
Contributor
Author
There was a problem hiding this comment.
All sounds good, new to the whole PR process/procedures with HA, how do you accept these changes? Do I make them on my side and commit them?
Member
|
Thank you, @digiblur for this PR. |
frenck
added
in-progress
Zone 3 example not needed
Contributor
Author
|
Corrections done. |
frenck
previously approved these changes
Jul 2, 2018
Member
|
Thanks for the quick actions @digiblur! ✅ Approved. Can be merged as soon as the parent PR gets merged. |
frenck
added
awaits-parent
Contributor
Author
|
Thanks for the review and help with my first PR of this project @frenck ! |
| - **panel_display** (*Optional*): Create a sensor called sensor.alarm_display to match the Alarm Keypad display. Default: `off` | ||
| - **zones** (*Optional*): AlarmDecoder has no way to tell us which zones are actually in use, so each zone must be configured in Home Assistant. For each zone, at least a name must be given. For more information on the available zone types, take a look at the [Binary Sensor](/components/binary_sensor.alarmdecoder/) docs. *Note: If no zones are specified, Home Assistant will not load any binary_sensor components.* | ||
| - **rfid** (*Optional*): The RF serial-number associated with RF zones. Providing this field allows Home Assistant to associate raw sensor data to a given zone, allowing direct monitoring of the state, battery, and supervision status. | ||
| - **relayaddr** (*Optional*): Address of the relay expander board to associate with the zone. (ex: 12, 13, 14, or 15). Typically used in cases where a panel will not send bypassed zones such as motion during an armed home state, the Vista 20P is an example of this. Alarmdecoder can emulate a zone expander board and the panel can be programmed to push zone events to this virtual expander. This allows the bypassed zone binary sensors to be utilized. One example is using bypassed motion sensors at night for motion-based automated lights while the system is armed with the motion sensor bypassed. |
Member
There was a problem hiding this comment.
Looks like there are two spaces between "this." and "Alarmdecoder can emulate".
Contributor
Author
|
Fixed the line above it too as I noticed the double space there as well. |
MartinHjelmare
approved these changes
Jul 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds the two optional configuration options referenced in the PR to the component.
home-assistant/core#15242
Pull request in home-assistant (if applicable): home-assistant/core#15242
Checklist:
current. New documentation for platforms/components and features should go tonext.