Add documentation for new Enphase Envoy platform#5638
Merged
Conversation
ghost
added
the
8 tasks
frenck
added
ready-for-review
frenck
previously approved these changes
Jul 2, 2018
Member
|
Looks great @jesserizzo! ✅ Approved. Can be merged as soon as the parent PR gets merged. |
frenck
added
awaits-parent
MartinHjelmare
requested changes
Aug 2, 2018
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
The name of the markdown file is incorrect. It should be prefixed with sensor..
| footer: true | ||
| logo: enphase.svg | ||
| ha_category: Energy | ||
| ha_release: 0.73 |
| required: false | ||
| type: string | ||
| monitored_conditions: | ||
| description: The list of conditions to display in the front end |
Member
There was a problem hiding this comment.
This doesn't have anything to do with the frontend per se. This decides what entities will be created, ie what data to collect.
| comments: false | ||
| sharing: true | ||
| footer: true | ||
| logo: enphase.svg |
Member
There was a problem hiding this comment.
The filename here doesn't match the included file.
| description: The local IP Address of your Envoy | ||
| required: true | ||
| type: string | ||
| name: |
Member
There was a problem hiding this comment.
This isn't included in the config schema of the platform.
Change title to sensor.enphase_envoy. Update version number. Fix typo in enphase logo file name.
| description: The local IP Address of your Envoy | ||
| required: true | ||
| type: string | ||
| name: |
MartinHjelmare
changed the title
dbrowndan
pushed a commit
to dbrowndan/home-assistant.io
that referenced
this pull request
Aug 8, 2018
* Create documentation for Enphase Envoy component * Add list of available conditions * Upload Enphase logo * Add second example configuration.yaml * Fix minor formatting errors * Fix configuration variables section * Fix minor typo * ✏️ Removed duplicate header * Changed ip to ip_address * Minor fixes Change title to sensor.enphase_envoy. Update version number. Fix typo in enphase logo file name. * Remove name key from configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant (if applicable): home-assistant/core#15081
Checklist:
current. New documentation for platforms/components and features should go tonext.