Skip to content

Clarify potential security issues; use safer example config#5617

Merged
fabaff merged 1 commit into
home-assistant:currentfrom
colinodell:patch-6
Jun 28, 2018
Merged

Clarify potential security issues; use safer example config#5617
fabaff merged 1 commit into
home-assistant:currentfrom
colinodell:patch-6

Conversation

@colinodell
Copy link
Copy Markdown
Contributor

Description:

This PR has two goals:

  1. Clarify exactly what can happen if use_x_forwarded_for is enabled
  2. Update the example configuration to be safer in case somebody blindly copy-pastes it

See home-assistant/core#14345 (comment) for why a misconfigured setting can be a problem.

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

Copy link
Copy Markdown
Contributor

@mnoorenberghe mnoorenberghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit b70454f into home-assistant:current Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants