Skip to content

Doorbirdpy v2#5529

Merged
arsaboo merged 1 commit into
home-assistant:nextfrom
Klikini:doorbird-v2-1
Nov 1, 2018
Merged

Doorbirdpy v2#5529
arsaboo merged 1 commit into
home-assistant:nextfrom
Klikini:doorbird-v2-1

Conversation

@Klikini
Copy link
Copy Markdown
Contributor

@Klikini Klikini commented Jun 11, 2018

Description:

Update for DoorBirdPy version 2.0.2.

Pull request in home-assistant (if applicable): home-assistant/core#14933

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@Klikini Klikini mentioned this pull request Jun 11, 2018
Merged
6 tasks
@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Jun 16, 2018

Can you please clean this PR to remove the unrelated commits.

@Klikini
Copy link
Copy Markdown
Contributor Author

Klikini commented Jun 16, 2018

I tried rebasing from upstream/current but it's still dragging in all those commits. Do you know how else I could do it?

@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Jun 16, 2018

The PR should be against the next branch.

@arsaboo arsaboo changed the base branch from current to next June 16, 2018 19:23
@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Jun 16, 2018

Rebase it against upstream/next.

@Klikini
Copy link
Copy Markdown
Contributor Author

Klikini commented Jun 16, 2018

Whoops. Thank you!

@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jun 24, 2018
frenck
frenck approved these changes Jun 24, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Approved and can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Jun 28, 2018
@stale
Copy link
Copy Markdown

stale Bot commented Aug 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale The PR had no activity for quite some time, and is marked as Stale label Aug 27, 2018
@Klikini
Copy link
Copy Markdown
Contributor Author

Klikini commented Aug 27, 2018

Still waiting on the parent PR.

@stale stale Bot removed the stale The PR had no activity for quite some time, and is marked as Stale label Aug 27, 2018
@stale
Copy link
Copy Markdown

stale Bot commented Oct 26, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added stale The PR had no activity for quite some time, and is marked as Stale and removed stale The PR had no activity for quite some time, and is marked as Stale labels Oct 26, 2018
@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Nov 1, 2018

Merging as the parent is now merged 👍

@arsaboo arsaboo merged commit dcb0cf1 into home-assistant:next Nov 1, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Klikini @arsaboo @frenck