Add dlna_dmr component#5474
Add dlna_dmr component#5474MartinHjelmare merged 9 commits intohome-assistant:nextfrom StevenLooman:next
Conversation
frenck
added
the
new-integration
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Looks good overall @StevenLooman!
Nevertheless, left you 2 comments, could you take a look? 👍
|
|
||
| Please note that some devices, such as Samsung TVs, are rather picky about the source used to play from. The TTS service might not work in combination with these devices. If the play_media service does not work, please try playing from a DLNA/DMS (such as [MiniDLNA](https://sourceforge.net/projects/minidlna/)). | ||
|
|
||
| Configuration variables: |
There was a problem hiding this comment.
Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration
| media_player: | ||
| - platform: dlna_dmr | ||
| url: http://192.168.0.10:9197/dmr | ||
| name: "TV living room" |
There was a problem hiding this comment.
We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps a user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.
|
Thank you for the review, will fix it soon! |
frenck
added
in-progress
frenck
added
ready-for-review
ghost
assigned
|
Thanks for the updates @StevenLooman! |
frenck
added
awaits-parent
| logo: dlna.png | ||
| ha_category: Media Player | ||
| featured: false | ||
| ha_release: 0.74 |
|
|
||
| Please note that some devices, such as Samsung TVs, are rather picky about the source used to play from. The TTS service might not work in combination with these devices. If the play_media service does not work, please try playing from a DLNA/DMS (such as [MiniDLNA](https://sourceforge.net/projects/minidlna/)). | ||
|
|
||
| ## {% linkable_title Configuration %} |
There was a problem hiding this comment.
Move this above the paragraph where we talk about the example config.
| url: http://192.168.0.10:9197/dmr | ||
| ``` | ||
|
|
||
| ## {% linkable_title Configuration %} |
There was a problem hiding this comment.
I meant that this header should be moved above the example paragraph.
|
Great, thanks! Please be sure to tag me in any future issues when any problems turn up. |
* Add dlna_dmr component * Remove no longer supported features * Add warning about picky devices * Add UDN to configuration; requested changes from review * ✏️ Tweaks * ⬆️ ha_release to 0.74 * Update media_player.dlna_dmr.markdown * Changes after review by @MartinHjelmare * Update media_player.dlna_dmr.markdown
3 participants
Description:
Pull request in home-assistant (if applicable): home-assistant/core#14749
Checklist:
current. New documentation for platforms/components and features should go tonext.