Skip to content

Add documentation for KIWI.KI smartlock#5381

Merged
balloob merged 4 commits into
home-assistant:nextfrom
c7h:c7h-patch-kiwi-lock
Jun 21, 2018
Merged

Add documentation for KIWI.KI smartlock#5381
balloob merged 4 commits into
home-assistant:nextfrom
c7h:c7h-patch-kiwi-lock

Conversation

@c7h
Copy link
Copy Markdown
Contributor

@c7h c7h commented May 16, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#14485

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label May 16, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c7h I left you some feedback, could you please take a look? 👍

Comment thread source/_components/lock.kiwi.markdown Outdated
ha_category: Lock
featured: false

ha_release: 0.69.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to the next major release (0.70).
New features are never released in minor releases.

Comment thread source/_components/lock.kiwi.markdown Outdated
password: mySecretPassword
```

Configuration variables:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :) 👍

@c7h
Copy link
Copy Markdown
Contributor Author

c7h commented Jun 1, 2018

@frenck The docs are updated now

Comment thread source/_components/lock.kiwi.markdown Outdated
ha_category: Lock
featured: false

ha_release: 0.70
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.72

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread source/_components/lock.kiwi.markdown Outdated
logo: kiwi.png
ha_category: Lock
featured: false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare changed the title added documentation for KIWI.KI smartlock Add documentation for KIWI.KI smartlock Jun 12, 2018
@balloob balloob merged commit 00c8d0d into home-assistant:next Jun 21, 2018
@balloob balloob added this to the 0.72 milestone Jun 22, 2018
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Jun 22, 2018
balloob pushed a commit that referenced this pull request Jun 22, 2018
* added documentation for KIWI.KI smartlock

* updated code review

* removed unused line

* bump ha_release to 0.72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked This PR has been manually picked and merged into the current branch new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants