Skip to content

Update Lametric notifiy#5358

Merged
MartinHjelmare merged 1 commit into
home-assistant:nextfrom
PhilRW:lametric
May 14, 2018
Merged

Update Lametric notifiy#5358
MartinHjelmare merged 1 commit into
home-assistant:nextfrom
PhilRW:lametric

Conversation

@PhilRW
Copy link
Copy Markdown
Contributor

@PhilRW PhilRW commented May 12, 2018

Description:
This documents home-assistant/core/pull/14414

Pull request in home-assistant (if applicable): home-assistant/core#14414

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@PhilRW PhilRW changed the title Lametric Update Lametric notifiy May 12, 2018
MartinHjelmare
MartinHjelmare previously approved these changes May 13, 2018
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can be merged when parent PR is merged.

fabaff
fabaff previously approved these changes May 14, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@fabaff fabaff changed the base branch from current to next May 14, 2018 14:37
@fabaff fabaff changed the base branch from next to current May 14, 2018 14:37
@fabaff fabaff added this to the 0.70 milestone May 14, 2018
@fabaff
Copy link
Copy Markdown
Member

fabaff commented May 14, 2018

Points to the wrong branch.

@PhilRW PhilRW changed the base branch from current to next May 14, 2018 14:39
@MartinHjelmare
Copy link
Copy Markdown
Member

@PhilRW please rebase your branch on next, to not include other commits than yours.

@PhilRW
Copy link
Copy Markdown
Contributor Author

PhilRW commented May 14, 2018

Oops, didn't notice that.

@PhilRW PhilRW dismissed stale reviews from fabaff and MartinHjelmare via 7973444 May 14, 2018 18:09
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MartinHjelmare MartinHjelmare merged commit e4048b6 into home-assistant:next May 14, 2018
Oro pushed a commit to Oro/home-assistant.github.io that referenced this pull request May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants