Skip to content

Allow HomeKit name to be customized#5314

Merged
cdce8p merged 5 commits into
home-assistant:nextfrom
schmittx:homekit-customize-accessory-information
May 11, 2018
Merged

Allow HomeKit name to be customized#5314
cdce8p merged 5 commits into
home-assistant:nextfrom
schmittx:homekit-customize-accessory-information

Conversation

@schmittx
Copy link
Copy Markdown
Contributor

@schmittx schmittx commented May 6, 2018

Description:
Allow name shown in HomeKit to be customized by specifying name within entity_config.

Pull request in home-assistant (if applicable): home-assistant/core#14159

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@cdce8p cdce8p self-assigned this May 6, 2018
@schmittx schmittx changed the title Allow HomeKit accessory information to be customized Allow HomeKit name to be customized May 11, 2018
Copy link
Copy Markdown
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just though about this. Can we move the example config and the change for the filter description to a new PR? That way we avoid potential merge conflicts.

You would need to fetch the current version first, since I did some small changes and rebased the branch.

@schmittx
Copy link
Copy Markdown
Contributor Author

Yeah, honestly I kind of forgot that I made the other changes along with the name customize stuff. My bad.

I'll split this out later tonight, we can merge the example config and filter description first then the name customize details in a separate PR.

@cdce8p
Copy link
Copy Markdown
Member

cdce8p commented May 11, 2018

Would work. I just haven't done it yet, so that we have the example here, but I guess the commit history works as well. Will do the change in a minute.

The new PR would need to be against the current branch though. So the changes wont be in there until they are merge in three weeks. That's why I wanted to split them, just in case somebody else does some other changes.

@cdce8p
Copy link
Copy Markdown
Member

cdce8p commented May 11, 2018

So, I reverted the changes that should go into the new PR.
Might be best if you take a look at 2e12003 and reverse it.

Will merge this shortly.

@cdce8p cdce8p added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 11, 2018
@cdce8p cdce8p merged commit 0b7a47d into home-assistant:next May 11, 2018
Oro pushed a commit to Oro/home-assistant.github.io that referenced this pull request May 20, 2018
@schmittx schmittx deleted the homekit-customize-accessory-information branch June 11, 2018 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants