add document for fan template#5296
Merged
Merged
Conversation
2 tasks
Contributor
Author
balloob
approved these changes
May 3, 2018
Danielhiversen
added a commit
that referenced
this pull request
May 3, 2018
This reverts commit fd5f1fc.
Member
|
This PR broke the build, I reverted the docs. |
Member
|
Please fix it and submit again |
Member
|
Found it, missed a |
Member
|
Please in the future test your branches 🤔 |
Member
|
And another missing quotes too that caused invalid yaml 3ca0be1 |
Contributor
Author
|
@balloob, I am sorry about that. I though we have branch build. Noted and will check my branch next time. Have u fixed the template? |
Member
|
It's fixed now 👍 . Somehow the test on this branch passed but then failed once they hit the main repo. That should have caught it normally. |
Contributor
Author
|
👍Thank you! |
Member
|
@balloob I'm not seeing this fix in |
Member
|
I put the fix in the rc branch, let me push that up to the next branch too |
Member
|
👍 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add document for template fans.
**Pull request in home-assistant
Checklist:
current. New documentation for platforms/components and features should go tonext.