Skip to content

Added Documentation for Xiaomi Cameras#5290

Merged
balloob merged 3 commits into
home-assistant:nextfrom
vaidyasr:next
Jun 21, 2018
Merged

Added Documentation for Xiaomi Cameras#5290
balloob merged 3 commits into
home-assistant:nextfrom
vaidyasr:next

Conversation

@vaidyasr
Copy link
Copy Markdown
Contributor

@vaidyasr vaidyasr commented May 2, 2018

Description:
Added documentation for Xiaomi Xiaofang 1080p Camera

Pull request in home-assistant (if applicable): home-assistant/core#14244

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@vaidyasr vaidyasr changed the title Added Documentation for Xiaofang Camera Added Documentation for XIaomi Cameras May 3, 2018
@vaidyasr vaidyasr changed the title Added Documentation for XIaomi Cameras Added Documentation for Xiaomi Cameras May 3, 2018
@dgomes dgomes added the new-integration This PR adds documentation for a new Home Assistant integration label Jun 7, 2018
@balloob balloob added this to the 0.72 milestone Jun 21, 2018
@balloob balloob merged commit 4a9a9b6 into home-assistant:next Jun 21, 2018
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Jun 21, 2018
balloob pushed a commit that referenced this pull request Jun 21, 2018
* Added Documentation for Xiaofang Camera

* Added documentation for both yi and xiaofang

* Update date
@OttoWinter
Copy link
Copy Markdown
Member

So the internal name of this platform is xiaomi, but the new docs file has the name camera.xiaofang (probably because something got changed in the review/change process).

Maybe this file should be renamed to source/_components/camera.xiaomi.markdown to match the internal name? Right now, the view source button seems to broken because of this too...

@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 22, 2018

Good catch.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 22, 2018

Fixed in 40d98e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked This PR has been manually picked and merged into the current branch new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants