Skip to content

Describe the new services added#5239

Merged
balloob merged 5 commits intohome-assistant:nextfrom
teharris1:next
May 5, 2018
Merged

Describe the new services added#5239
balloob merged 5 commits intohome-assistant:nextfrom
teharris1:next

Conversation

@teharris1
Copy link
Copy Markdown
Contributor

Description:
New services were added to support Insteon All-Linking.

Pull request in home-assistant (if applicable): home-assistant/core#14065

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teharris1, Thank you for your PR. I've reviewed it and left some comments. Could you please take a look? That would be awesome 😎

---
layout: page
title: "Insteon PLM"
description: "Instructions on how to setup an Insteon USB PLM locally within Home Assistant."
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect, please leave it as it was.

product_key: PRODUCT_KEY
```
Configuration variables:
- **port** (*Required*): The port for your device, e.g., `/dev/ttyUSB0`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change this, the previous version was actually correct.

The only configuration item that is absolutely necessary is the port so that
Home Assistant can connect to the PLM. This will expose all the supported INSTEON
devices which exist in the modem's ALL-Link database. However, devices will
only be shown by their INSTEON hex address (e.g., "1A.2B.3C") which can be a bit
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave this intact, since it was perfectly fine.

Comment thread source/_components/insteon_plm.markdown Outdated
[Development Tools] service calls. The following services are available:

In order for any two Insteon devices to talk with one another, they must be
linked. For an overview of device linking please read the Insteon page on
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma: linking please read -> linking, please read

Comment thread source/_components/insteon_plm.markdown Outdated
linked. For an overview of device linking please read the Insteon page on
[understanding linking]. The Insteon PLM module supports All-Linking through
[Development Tools] service calls. The following services are available:
- **insteon_plm.add_all_link**: Tells the Insteom Modem (IM) start All-Linking
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insteom -> Insteon

Comment thread source/_components/insteon_plm.markdown Outdated
is set to delete the link, press the link button on the corresponding device
to complete the process.
- **insteon_plm.load_all_link_database**: Load the All-Link Database for a
device. WARNING - Loading a device All-LInk database is very time consuming
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All-LInk -> All-Link

Comment thread source/_components/insteon_plm.markdown Outdated
to complete the process.
- **insteon_plm.load_all_link_database**: Load the All-Link Database for a
device. WARNING - Loading a device All-LInk database is very time consuming
and inconsistant. This may take a LONG time and may need to be repeated to
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistant -> inconsistent

Comment thread source/_components/insteon_plm.markdown Outdated
[insteonplm] Python module. Please see the documentation on the [insteonplm]
GitHub site. Alternatively, you can download [HouseLinc] which runs on any
Windows PC, or you can use [Insteon Terminal] which is open source and runs
on most platforms. HouseLinc is no longer supported by SmartHome but it still
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More active voice suggestion (and missing comma):
SmartHome no longer supports HouseLinc, but it still

@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Apr 24, 2018
@teharris1
Copy link
Copy Markdown
Contributor Author

@frenck Thanks for reviewing this PR. Hopefully my changes met your expectations. The associated code PR is still sitting out there after over a week. Any way you can help move the code review of the that PR forward? Thanks

balloob
balloob previously approved these changes May 5, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented May 5, 2018

@teharris1 there has been a build error because of a change you made in this PR. From the netlify build:

Error: could not read file /opt/build/repo/source/_components/insteon_plm.markdown: invalid byte sequence in UTF-8
5:32:57 PM: Liquid Exception: invalid byte sequence in UTF-8 in /opt/build/repo/source/_components/insteon_plm.markdown

@balloob balloob added this to the 0.69 milestone May 5, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented May 5, 2018

Please address asap so it can be part of the release.

@teharris1
Copy link
Copy Markdown
Contributor Author

@balloob Working on it right now.

@balloob
Copy link
Copy Markdown
Member

balloob commented May 5, 2018

Looks like editting it in the GitHub online editor converts it to UTF-8, let's see if that worked.

@balloob balloob merged commit e46a4d4 into home-assistant:next May 5, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented May 5, 2018

Thanks! Cherry-picking this for RC branch.

balloob pushed a commit that referenced this pull request May 5, 2018
* Describe the new services added

* Edits per review

* UTF-8 error

* UTF-8 Error

* Convert to utf-8
Oro pushed a commit to Oro/home-assistant.github.io that referenced this pull request May 20, 2018
* Describe the new services added

* Edits per review

* UTF-8 error

* UTF-8 Error

* Convert to utf-8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants