Skip to content

Add support for multiple Doorbird stations#5205

Merged
syssi merged 9 commits intohome-assistant:currentfrom
oblogic7:doorbird_multiple_devices
Jun 10, 2018
Merged

Add support for multiple Doorbird stations#5205
syssi merged 9 commits intohome-assistant:currentfrom
oblogic7:doorbird_multiple_devices

Conversation

@oblogic7
Copy link
Copy Markdown
Contributor

@oblogic7 oblogic7 commented Apr 19, 2018

Description:
Edits documentation for supporting multiple devices.

Pull request in home-assistant (if applicable): home-assistant/core#13994

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the [standards][standards].

@oblogic7 oblogic7 changed the title Doorbird multiple device support Doorbird multiple devices and binary_sensor May 6, 2018
@alandtse
Copy link
Copy Markdown
Contributor

@oblogic7 Good work on this. I just closed my own PR because I forgot to check to see if someone else did it already. Please remember to conform the docs to your code so we can see this in the next release. ;)

@oblogic7
Copy link
Copy Markdown
Contributor Author

oblogic7 commented May 22, 2018 via email

@oblogic7
Copy link
Copy Markdown
Contributor Author

Documentation has been updated to match changes on home-assistant/core#13994

@oblogic7 oblogic7 changed the title Doorbird multiple devices and binary_sensor Doorbird Component Enhancements May 22, 2018
@syssi
Copy link
Copy Markdown
Member

syssi commented May 23, 2018

Could you recycle and update the config section of #5414. It's the preferred format for config schemas.

syssi
syssi previously approved these changes May 23, 2018
@syssi syssi dismissed their stale review May 23, 2018 20:34

Approved by accident. :-)

@syssi
Copy link
Copy Markdown
Member

syssi commented May 23, 2018

Please update the section, too. It doesn't include the multiple device support right now.

@syssi
Copy link
Copy Markdown
Member

syssi commented Jun 10, 2018

Please rebase the docs and fix the merge conflict. Does all changes still apply?

@oblogic7
Copy link
Copy Markdown
Contributor Author

Yes, it is up to date with all changes on home-assistant/core#13994

@syssi syssi changed the title Doorbird Component Enhancements Add support for multiple Doorbird stations Jun 10, 2018
@syssi syssi merged commit 5841601 into home-assistant:current Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants