Skip to content

Add niko-home-control documentation#5137

Merged
fabaff merged 2 commits intohome-assistant:nextfrom
NoUseFreak:feature/niko-home-control
Nov 12, 2018
Merged

Add niko-home-control documentation#5137
fabaff merged 2 commits intohome-assistant:nextfrom
NoUseFreak:feature/niko-home-control

Conversation

@NoUseFreak
Copy link
Copy Markdown
Contributor

Description:

Pull request in home-assistant (if applicable): home-assistant/core#13755

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

host: 192.168.1.123
```

Configuration variables:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---

The `niko_home_control` platform allows you to integrate your [Niko Home Control](https://www.niko.eu/enus/products/niko-home-control) into Home Assistant.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you would describe less briefly what types of devices are supported / what a potential user of the component/platform can expect to have with this platform.


Configuration variables:

- **host** (*Required*): The ip address your Niko Home is on,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only parameter, or was something left out?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this might be a hostname as well?
Secondly, ip needs to be capitalized; IP.

frenck
frenck previously requested changes Apr 14, 2018

Configuration variables:

- **host** (*Required*): The ip address your Niko Home is on,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this might be a hostname as well?
Secondly, ip needs to be capitalized; IP.

footer: true
ha_category: Light
ha_iot_class: "Local Polling"
ha_release: 0.36
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect release number, 0.36 is pretty old. The suggestion is to update it to 0.68.

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 14, 2018

@NoUseFreak Thank you for this PR. I and @rytilahti reviewed the PR and left you some comments.
Could you please take a look? 👍

Another suggestion, maybe, add the logo of Niko to the documentation as well.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Apr 14, 2018
@stale
Copy link
Copy Markdown

stale Bot commented Jun 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale The PR had no activity for quite some time, and is marked as Stale label Jun 13, 2018
@stale stale Bot closed this Jun 20, 2018
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Nov 12, 2018

Reopen for home-assistant/core#18019.

@fabaff fabaff reopened this Nov 12, 2018
@stale stale Bot removed the stale The PR had no activity for quite some time, and is marked as Stale label Nov 12, 2018
@fabaff fabaff dismissed frenck’s stale review November 12, 2018 14:56

Comments addressed

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@fabaff fabaff merged commit 659e0a6 into home-assistant:next Nov 12, 2018
@frenck frenck added next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants