Skip to content

Added documentation for gogogate2#5023

Merged
fabaff merged 5 commits into
home-assistant:nextfrom
dlbroadfoot:gogogate2
Apr 6, 2018
Merged

Added documentation for gogogate2#5023
fabaff merged 5 commits into
home-assistant:nextfrom
dlbroadfoot:gogogate2

Conversation

@dlbroadfoot
Copy link
Copy Markdown
Contributor

@dlbroadfoot dlbroadfoot commented Mar 26, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#13467

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Apr 2, 2018
ip_address: 192.168.1.200
```

Configuration variables:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration


- **username** (*Required*): Your Gogogate2 account username.
- **password** (*Required*): Your Gogogate2 account password.
- **ip_address** (*Required*): IP address of your Gogogate2 device
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optional api_key configuration variable is missing in the docs but is present in the code.

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 2, 2018

Thank you for this PR, @dlbroadfoot!

I've left you some comments to take a look at 👍

frenck
frenck previously approved these changes Apr 3, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 3, 2018

Thanks, @dlbroadfoot for updating the PR! 🥇

Looks good and can be merged as soon as the parent PR gets merged.

fabaff
fabaff previously approved these changes Apr 6, 2018
@fabaff fabaff merged commit 8aaf154 into home-assistant:next Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants