Updated documentation for SABnzbd.#4836
Merged
Merged
Conversation
7 tasks
frenck
added
the
new-integration
Member
|
Rebased the PR in order to fix the build |
frenck
previously approved these changes
Mar 23, 2018
Member
|
Thanks, @jeradM! 🥇 Can be merged as soon as the parent PR gets merged. |
frenck
approved these changes
Apr 6, 2018
Member
Author
|
Yep no problem. It looks like #4942 modified the old documentation |
Member
Author
|
Rebased next branch. Merge conflicts should be resolved now |
Member
|
There is still a merge conflict. The sensor page should not be removed, just streamlined and link to the component page, saying it's required to set up sensors. |
Member
Author
|
Ah it was a new merge conflict from #5230. Should be good to go now. I updated ha_release to 0.69, but I'm wondering, since this is a breaking change, should it wait until 0.70 so it makes it into an early beta? |
Member
|
Yeah, this will not go out in 0.69 but 0.70. |
frenck
approved these changes
May 16, 2018
Member
|
Thank you for this @jeradM. |
Oro
pushed a commit
to Oro/home-assistant.github.io
that referenced
this pull request
May 20, 2018
* Updated documentation for SABnzbd. * Added a period * ✏️ Tweaks * ⬆️ ha_release -> 0.68 * Keep sensor page with link to component. Fix merge conflict from home-assistant#5230 * ⬆️ ha_release -> 0.70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updated documentation for sensor.sabnzbd to reflect that it has been moved to a component with additional configuration options and services.
Pull request in home-assistant (if applicable): home-assistant/core#12915
Checklist:
current. New documentation for platforms/components and features should go tonext.