sensor.alpha_vantage: removed Google as default stock#4618
Merged
fabaff merged 3 commits intohome-assistant:nextfrom Feb 11, 2018
Merged
sensor.alpha_vantage: removed Google as default stock#4618fabaff merged 3 commits intohome-assistant:nextfrom
fabaff merged 3 commits intohome-assistant:nextfrom
Conversation
Contributor
|
The config indicated is no longer complete. We need to indicate that one of them (forex or stocks) is required. |
arsaboo
previously approved these changes
Feb 10, 2018
Contributor
arsaboo
left a comment
There was a problem hiding this comment.
Looks good...can me merged when the parent PR is merged 👍
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
after the change to the code, we also need to remove the default stock Google from the documentation
Pull request in home-assistant (if applicable): home-assistant/core#12252
Checklist:
current. New documentation for platforms/components and features should go tonext.