Skip to content

sensor.alpha_vantage: removed Google as default stock#4618

Merged
fabaff merged 3 commits intohome-assistant:nextfrom
ChristianKuehnel:alpha_vantage
Feb 11, 2018
Merged

sensor.alpha_vantage: removed Google as default stock#4618
fabaff merged 3 commits intohome-assistant:nextfrom
ChristianKuehnel:alpha_vantage

Conversation

@ChristianKuehnel
Copy link
Copy Markdown
Contributor

Description:
after the change to the code, we also need to remove the default stock Google from the documentation

Pull request in home-assistant (if applicable): home-assistant/core#12252

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Feb 10, 2018

The config indicated

sensor:
  - platform: alpha_vantage
    api_key: YOUR_API_KEY

is no longer complete. We need to indicate that one of them (forex or stocks) is required.

arsaboo
arsaboo previously approved these changes Feb 10, 2018
Copy link
Copy Markdown
Contributor

@arsaboo arsaboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...can me merged when the parent PR is merged 👍

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 9329aa7 into home-assistant:next Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants