Changed note about base url#4557
Conversation
| ``` | ||
|
|
||
| <p class='note'> | ||
| If you are running Home Assistant over SSL or from within a container, you will have to setup a base URL (`base_url`) inside the [http component](/components/http/). |
There was a problem hiding this comment.
If a reverse proxy is in use, base_url isn't needed. I'm not sure though how to call that out, without adding confusion though.
There was a problem hiding this comment.
I agree with @DubhAd. You could point to it without saying why.
Like:
Depending on your setup, you might need to set a base URL (`base_url`) inside the [http component](/components/http/).
There was a problem hiding this comment.
With this change I had just moved what was currently in place as I thought that was already the correct wording 😄 I can change it to your suggestion but I'm not sure how to add more commits to an open pull request or if I should just create a new pull request. Any advice would be helpful 👍 Cheers
There was a problem hiding this comment.
Simply choose the "Files changed" tab here on GitHub (top of the PR), hit the edit button (pencil) button on the file header, and update 👍
|
Can be merged as soon as the build passes. |
|
Hmmm, the build fails on something not in this branch? |
Changed the location to be above the fold
|
Rebased, merging it in. |
* Changed note about base url Changed the location to be above the fold * ✏️ Updating the note + some minors
Changed the location to be above the fold
Description:
I have noticed a few threads in the home assistant community where people have made this mistake of not configuring their base url when trying to get TTS to work, I think its quite easy to miss since you can just add the two line config at the top and it will appear to give you something.
Not a major change but thought it might help others 👍
home-assistant/home-assistant#
Checklist:
current. New documentation for platforms/components and features should go tonext.