Skip to content

Changed note about base url#4557

Merged
frenck merged 2 commits into
home-assistant:currentfrom
JamesMcClelland:patch-1
Mar 15, 2018
Merged

Changed note about base url#4557
frenck merged 2 commits into
home-assistant:currentfrom
JamesMcClelland:patch-1

Conversation

@JamesMcClelland
Copy link
Copy Markdown
Contributor

Changed the location to be above the fold

Description:

I have noticed a few threads in the home assistant community where people have made this mistake of not configuring their base url when trying to get TTS to work, I think its quite easy to miss since you can just add the two line config at the top and it will appear to give you something.

Not a major change but thought it might help others 👍

home-assistant/home-assistant#

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

Comment thread source/_components/tts.markdown Outdated
```

<p class='note'>
If you are running Home Assistant over SSL or from within a container, you will have to setup a base URL (`base_url`) inside the [http component](/components/http/).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a reverse proxy is in use, base_url isn't needed. I'm not sure though how to call that out, without adding confusion though.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @DubhAd. You could point to it without saying why.
Like:

Depending on your setup, you might need to set a base URL (`base_url`) inside the [http component](/components/http/).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change I had just moved what was currently in place as I thought that was already the correct wording 😄 I can change it to your suggestion but I'm not sure how to add more commits to an open pull request or if I should just create a new pull request. Any advice would be helpful 👍 Cheers

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply choose the "Files changed" tab here on GitHub (top of the PR), hit the edit button (pencil) button on the file header, and update 👍

frenck
frenck previously approved these changes Mar 13, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 13, 2018

Can be merged as soon as the build passes.

@frenck frenck self-assigned this Mar 13, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 14, 2018

Hmmm, the build fails on something not in this branch?
Need to pull in changes from current maybe?

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 15, 2018

Rebased, merging it in.

@frenck frenck merged commit e62bb85 into home-assistant:current Mar 15, 2018
nielstron pushed a commit to nielstron/home-assistant.github.io that referenced this pull request Mar 22, 2018
* Changed note about base url

Changed the location to be above the fold

* ✏️ Updating the note + some minors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants