Skip to content

Added mychevy docs#4410

Merged
fabaff merged 3 commits into
home-assistant:nextfrom
sdague:mychevy
Jan 17, 2018
Merged

Added mychevy docs#4410
fabaff merged 3 commits into
home-assistant:nextfrom
sdague:mychevy

Conversation

@sdague
Copy link
Copy Markdown
Contributor

@sdague sdague commented Jan 13, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#11409

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Jan 14, 2018
Comment thread source/_components/mychevy.markdown Outdated
comments: false
sharing: true
footer: true
logo: tesla.png
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect logo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Comment thread source/_components/mychevy.markdown Outdated

The `MyChevy` component communicates with the
[my.chevrolet](https://my.chevrolet.com) website using selenium to log
in as a your user, and screen scrape the data provided. GM does not
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in as a your user -> in as your user

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Comment thread source/_components/mychevy.markdown Outdated
[my.chevrolet](https://my.chevrolet.com) website using selenium to log
in as a your user, and screen scrape the data provided. GM does not
make it easy to sign up for any official development program, so this
provides a work around to get access to your data.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work around -> workaround

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Comment thread source/_components/mychevy.markdown Outdated
password: password
```

Configuration variables:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdague You still need to remove this header...

Comment thread source/_components/mychevy.markdown Outdated
F). One of the provided sensors is a status sensor which indicates if
we got connectivity with the car on the last polling cycle or not.

The "API" for this is written by webscraping. As such, it only
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webscraping -> web scraping

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Comment thread source/_components/mychevy.markdown Outdated

The "API" for this is written by webscraping. As such, it only
currently is known to work if you have a Chevy Bolt EV, and only 1
chevy car connected to OnStar. Patches for extended support should go
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chevy -> Chevy

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Comment thread source/_components/mychevy.markdown Outdated
currently is known to work if you have a Chevy Bolt EV, and only 1
chevy car connected to OnStar. Patches for extended support should go
to the https://github.com/sdague/mychevy project first, then
home-assistant can be extended.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

home-assistant -> Home Assistant

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 14, 2018

@sdague Could you please take a look at my review comments? 👍

@sdague
Copy link
Copy Markdown
Contributor Author

sdague commented Jan 15, 2018

ACK. Thank you for the review and catching those issues.

Comment thread source/_components/mychevy.markdown Outdated
footer: true
logo: chevy.png
ha_category: Hub
ha_release: 0.61
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.61 is already shipped. Please update this to 0.62

@frenck frenck self-assigned this Jan 16, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 16, 2018

Can be merged as soon as the build passes.

@fabaff fabaff merged commit f8ab881 into home-assistant:next Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants