Skip to content

Hyperion light, new features#4376

Merged
frenck merged 2 commits into
home-assistant:nextfrom
starkillerOG:patch-1
Jan 14, 2018
Merged

Hyperion light, new features#4376
frenck merged 2 commits into
home-assistant:nextfrom
starkillerOG:patch-1

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Jan 8, 2018

Description:
Added brightness, HDMI and effect support in my pull request.
This includes two new optional variables that can be configured.

Pull request in home-assistant (if applicable): home-assistant/core#11543

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many non related commits in this branch. Please rebase and force push or open a new PR and link to this one.

@frenck frenck self-assigned this Jan 14, 2018
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jan 14, 2018
Added brightness, HDMI and effect support in my pull request.
This includes two new optional variables that can be configured.
@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 14, 2018

I've rebased the PR onto the current next branch.

@frenck frenck dismissed MartinHjelmare’s stale review January 14, 2018 20:13

Rebased as requested

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 14, 2018

Can be merged as soon as the build passes.

@frenck frenck added this to the 0.61 milestone Jan 14, 2018
@frenck frenck removed their assignment Jan 14, 2018
@frenck frenck merged commit c222603 into home-assistant:next Jan 14, 2018
@frenck frenck removed this from the 0.61 milestone Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants